From: levinse Date: Thu, 9 Dec 2010 19:26:20 +0000 (+0000) Subject: -change ikano.pm to use the new part_pkg_vendor, RT7111 X-Git-Tag: TORRUS_1_0_9~27 X-Git-Url: http://git.freeside.biz/gitweb/?a=commitdiff_plain;h=57fecbd959fd5d72b20105161b7e3df94cbedd03;p=freeside.git -change ikano.pm to use the new part_pkg_vendor, RT7111 -implement service expiry and add export expire to ikano, RT7111 -fix edit part_pkg bug, RT7111 --- diff --git a/FS/FS/cust_pkg.pm b/FS/FS/cust_pkg.pm index e3f4777aa..b97bc93a1 100644 --- a/FS/FS/cust_pkg.pm +++ b/FS/FS/cust_pkg.pm @@ -661,7 +661,25 @@ sub cancel { } my %svc; - unless ( $date ) { + if ( $date ) { + # copied from below + foreach my $cust_svc ( + #schwartz + map { $_->[0] } + sort { $a->[1] <=> $b->[1] } + map { [ $_, $_->svc_x->table_info->{'cancel_weight'} ]; } + qsearch( 'cust_svc', { 'pkgnum' => $self->pkgnum } ) + ) { + + my $error = $cust_svc->cancel( ('date' => $date) ); + + if ( $error ) { + $dbh->rollback if $oldAutoCommit; + return "Error expiring cust_svc: $error"; + } + } + + } else { foreach my $cust_svc ( #schwartz map { $_->[0] } diff --git a/FS/FS/cust_svc.pm b/FS/FS/cust_svc.pm index 7b866fad3..0a58d559a 100644 --- a/FS/FS/cust_svc.pm +++ b/FS/FS/cust_svc.pm @@ -109,7 +109,7 @@ If there is an error, returns the error, otherwise returns false. =cut sub cancel { - my $self = shift; + my($self,%opt) = @_; local $SIG{HUP} = 'IGNORE'; local $SIG{INT} = 'IGNORE'; @@ -133,19 +133,26 @@ sub cancel { my $svc = $self->svc_x; if ($svc) { - - my $error = $svc->cancel; - if ( $error ) { - $dbh->rollback if $oldAutoCommit; - return "Error canceling service: $error"; - } - $error = $svc->delete; #this deletes this cust_svc record as well - if ( $error ) { - $dbh->rollback if $oldAutoCommit; - return "Error deleting service: $error"; + if ( %opt && $opt{'date'} ) { + my $error = $svc->expire($opt{'date'}); + if ( $error ) { + $dbh->rollback if $oldAutoCommit; + return "Error expiring service: $error"; + } + } else { + my $error = $svc->cancel; + if ( $error ) { + $dbh->rollback if $oldAutoCommit; + return "Error canceling service: $error"; + } + $error = $svc->delete; #this deletes this cust_svc record as well + if ( $error ) { + $dbh->rollback if $oldAutoCommit; + return "Error deleting service: $error"; + } } - } else { + } elsif ( !%opt ) { #huh? warn "WARNING: no svc_ record found for svcnum ". $self->svcnum. diff --git a/FS/FS/part_export/ikano.pm b/FS/FS/part_export/ikano.pm index 30e2bac7f..ac1e5785a 100644 --- a/FS/FS/part_export/ikano.pm +++ b/FS/FS/part_export/ikano.pm @@ -52,7 +52,6 @@ sub dsl_pull { # vendor_order_id, vendor_qual_id, vendor_order_type, pushed, monitored, # last_pull, address (from qual), contact info, ProductCustomId my($self, $svc_dsl, $threshold) = (shift, shift, shift); - $self->loadmod; my $result = $self->valid_order($svc_dsl,'pull'); return $result unless $result eq ''; @@ -332,7 +331,9 @@ sub qual_html { my $list = "Qualifying Packages: