[freeside-commits] freeside/httemplate/misc/process cancel_pkg.html, 1.3, 1.4

[Ivan,,,]

Update of /home/cvs/cvsroot/freeside/httemplate/misc/process
In directory wavetail:/tmp/cvs-serv4430

Modified Files:
	cancel_pkg.html 
Log Message:
correct a typo, and <%init> helps alot

Index: cancel_pkg.html
===================================================================
RCS file: /home/cvs/cvsroot/freeside/httemplate/misc/process/cancel_pkg.html,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -d -r1.3 -r1.4
--- cancel_pkg.html	23 Oct 2006 08:47:07 -0000	1.3
+++ cancel_pkg.html	29 Jan 2007 21:11:49 -0000	1.4
@@ -1,76 +1,75 @@
-%
-%
-%#untaint method
-%my $method = $cgi->param('method');
-%$method =~ /^(cancel|expire|suspend)$/ || die "Illegal method";
-%$method = $1;
+<%init>
+#untaint method
+my $method = $cgi->param('method');
+$method =~ /^(cancel|expire|suspend)$/ || die "Illegal method";
+$method = $1;
 
-%#untaint pkgnum
-%my $pkgnum = $cgi->param('pkgnum');
-%$pkgnum =~ /^(\d+)$/ || die "Illegal pkgnum";
-%$pkgnum = $1;
-%
-%#untaint reasonnum
-%my $reasonnum = $cgi->param('reasonnum');
-%$reasonnum =~ /^(-?\d+)$/ || die "Illegal reasonnum";
-%$reasonnum = $1;
-%
-%my $date = time;
-%if ($method eq 'expire'){
-%  #untaint date
-%  $date = $cgi->param('date');
-%  str2time($cgi->param('date')) =~ /^(\d+)$/ || die "Illegal date";
-%  $date = $1;
-%}
-%
-%my $cust_pkg = qsearchs( 'cust_pkg', {'pkgnum'=>$pkgnum} );
-%
-%
-%my $oldAutoCommit = $FS::UID::AutoCommit;
-%local $FS::UID::AutoCommit = 0;
-%my $dbh = dbh;
-%
-%my $otaker = $FS::CurrentUser::CurrentUser->name;
-%$otaker = $FS::CurrentUser::CurrentUser->username
-%  if ($otaker eq "User, Legacy");
-%
-%my $error = '';
-%if ($reasonnum == -1) {
-%
-%  $error = 'Enter a new reason (or select an existing oen)'
-%    unless $cgi->param('newreasonnum') !~ /^\s*$/;
-%
-%  my $reason = new FS::reason({ 'reason_type' => $cgi->param('newreasonnumT'),
-%                                'reason'      => $cgi->param('newreasonnum'),
-%                              });
-%  $error ||= $reason->insert;
-%  $reasonnum = $reason->reasonnum
-%    unless $error;
-%}
-%
-%unless ($error) {
-%  if ($method eq 'expire'){
-%    my %hash = $cust_pkg->hash;
-%    $hash{'expire'}=$date;
-%    my $new = new FS::cust_pkg (\%hash);
-%    $error = $new->replace($cust_pkg, 'reason' => $reasonnum);
-%  }else{
-%    $error = $cust_pkg->$method( 'reason' => $reasonnum );
-%  }
-%}
-%
-%if ($error) {
-%  $cgi->param('error', $error);
-%  $dbh->rollback if $oldAutoCommit;
-%  print $cgi->redirect(popurl(2). "cancel_pkg.html?". $cgi->query_string );
-%}
-%
-%$dbh->commit or die $dbh->errstr if $oldAutoCommit;
-%
-% my %past = ( 'cancel'  => 'cancelled',
-%              'expire'  => 'expired',
-%              'suspend' => 'suspended',
-%            );
+#untaint pkgnum
+my $pkgnum = $cgi->param('pkgnum');
+$pkgnum =~ /^(\d+)$/ || die "Illegal pkgnum";
+$pkgnum = $1;
+
+#untaint reasonnum
+my $reasonnum = $cgi->param('reasonnum');
+$reasonnum =~ /^(-?\d+)$/ || die "Illegal reasonnum";
+$reasonnum = $1;
+
+my $date = time;
+if ($method eq 'expire'){
+  #untaint date
+  $date = $cgi->param('date');
+  str2time($cgi->param('date')) =~ /^(\d+)$/ || die "Illegal date";
+  $date = $1;
+}
+
+my $cust_pkg = qsearchs( 'cust_pkg', {'pkgnum'=>$pkgnum} );
+
+my $oldAutoCommit = $FS::UID::AutoCommit;
+local $FS::UID::AutoCommit = 0;
+my $dbh = dbh;
+
+my $otaker = $FS::CurrentUser::CurrentUser->name;
+$otaker = $FS::CurrentUser::CurrentUser->username
+  if ($otaker eq "User, Legacy");
+
+my $error = '';
+if ($reasonnum == -1) {
+
+  $error = 'Enter a new reason (or select an existing one)'
+    unless $cgi->param('newreasonnum') !~ /^\s*$/;
+
+  my $reason = new FS::reason({ 'reason_type' => $cgi->param('newreasonnumT'),
+                                'reason'      => $cgi->param('newreasonnum'),
+                              });
+  $error ||= $reason->insert;
+  $reasonnum = $reason->reasonnum
+    unless $error;
+}
+
+unless ($error) {
+  if ($method eq 'expire'){
+    my %hash = $cust_pkg->hash;
+    $hash{'expire'}=$date;
+    my $new = new FS::cust_pkg (\%hash);
+    $error = $new->replace($cust_pkg, 'reason' => $reasonnum);
+  }else{
+    $error = $cust_pkg->$method( 'reason' => $reasonnum );
+  }
+}
+
+if ($error) {
+  $cgi->param('error', $error);
+  $dbh->rollback if $oldAutoCommit;
+  print $cgi->redirect(popurl(2). "cancel_pkg.html?". $cgi->query_string );
+}
+
+$dbh->commit or die $dbh->errstr if $oldAutoCommit;
+
+ my %past = ( 'cancel'  => 'cancelled',
+              'expire'  => 'expired',
+              'suspend' => 'suspended',
+            );
+</%init>
 <% header("Package $past{$method}") %>
   <SCRIPT TYPE="text/javascript">
     window.top.location.reload();