[freeside-users] RFC: improvements for handling of setup fees

[Scott Edwards]

Thanks for the reply Jeff.  I neglected to send you the reply I had
earlier, however I believe I've help clarify both questions I opened
with.

On Thu, Jul 2, 2009 at 11:10 PM, Jeff Finucane<jeff at cmheleu.cmh.net> wrote:
> On Thu, Jul 02, 2009 at 10:50:15PM -0600, Scott Edwards wrote:
>>
>> The setup fee is not billed if the date is filled out before the
>> invoice is created.  As a result, it's never charged.  Does it make
>> sense to update the schema so there's a reference to the line item it
>> was billed for, and make that the criteria for billing the fee, after
>> the setup date?
>>
>
>  Not sure what problem you are trying to solve, but I don't think a
> schema change is required.  First, the freeside-daily process has
> a -s switch to rebill setup in the event that is appropriate (usually
> as a result of import).  Second, if you want a price plan to decide
> on when the setup should be billed, it can check for cust_bill_pkg
> records with a matching pkgnum and a non-zero/null setup.  This requires
> some code changes, but no schema changes.
>

My colleague Gilbert can explain,

---------- Forwarded message ----------
From: Gilbert Rebeiro
Date: Mon, Jul 6, 2009 at 11:26 AM
Subject: Re: RFC: improvements for handling of setup fees
To: Scott Edwards <supadupa at gmail.com>

We have a wholesale customer, this means they place several orders
during the month, each order having it's own setup date.

Ideally we would like to run freeside-daily at the end of the month
(on the last day of the month) and have freeside create one invoice
with all services provisioned during this month - prorating the
activity according to each services' setup date.

the -s switch is confusing, and makes me feel like freeside could
rebill something that hasn't been billed yet.

That is why we suggested having 2 fields.
One is a setup billed. field
one is the date that the setup was done.

Is this better?


>> Environment:
>>
>> We've upgraded to Freeside HEAD as of a few weeks ago, and updated
>> past the postal invoice gotcha. (just the code that's affected). We
>> moved to HEAD mainly for the voip features, as we didn't want to wait
>> any longer for a stable snapshot to release.
>
> wtf on 'postal invoice gotcha?'

http://freeside.biz/cgi-bin/viewvc.cgi/freeside/FS/FS/cust_main.pm?r1=1.428&r2=1.429&pathrev=HEAD&sortby=date

We upgraded sometime between those two revisions, and customers
without postal invoices (aka, everyone we have afaik) bombed out.
Running freeside daily would give us this:

Can't call method "part_pkg" without a package or object reference
at /usr/local/share/perl/5.10.0/FS/cust_main.pm line 2444.
Issuing rollback() for database handle being DESTROY'd without explicit
disconnect() at /usr/local/share/perl/5.10.0/FS/cust_main.pm line 2444.

Thanks,


Scott Edwards
-- Daxal Communications - http://daxal.com/?from=freeside+list